feat: harden notifications and related flows#170
Merged
Conversation
Contributor
|
🚨 PR 본문이 비어있습니다! 아래 템플릿을 복사하여 PR 내용을 작성해주세요. 📝 개요
💻 작업 내용
✅ PR 체크리스트
🔗 관련 이슈
스크린샷 (선택)
|
|
Caution Review failedThe pull request is closed. Walkthrough알림 서비스에 디버그 이벤트 로깅, 마케팅 동의 검증, 인증된 사용자 기반 권한 검사 기능을 추가했습니다. 또한 한국 시간대(Asia/Seoul) 적용, NotificationType에 마케팅 플래그 추가, 테스트 재작성이 포함되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
actor User as 인증된 사용자
participant Controller as NotificationController
participant Service as NotificationService
participant Repo as NotificationRepository
participant Domain as Notification 객체
User->>Controller: readNotification(notificationId)
Controller->>Service: readNotification(userId, notificationId)
Service->>Repo: 알림 ID로 알림 조회
Repo-->>Service: Notification 반환
Service->>Domain: 알림 수신자 ID 확인
alt userId == 알림 수신자 ID
Service->>Domain: 읽음 상태로 표시
Service->>Repo: 알림 저장
Repo-->>Service: 저장 완료
Service-->>Controller: 성공
Controller-->>User: ApiResponse.success(null)
else userId != 알림 수신자 ID
Service-->>Controller: IllegalArgumentException 발생
Controller-->>User: 오류 응답
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
릴리스 노트
New Features
Improvements
Documentation
Tests